Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate lidar_det3d.md into corresponding Chinese version #1368

Merged
merged 8 commits into from
Apr 13, 2022
Merged

translate lidar_det3d.md into corresponding Chinese version #1368

merged 8 commits into from
Apr 13, 2022

Conversation

YuanxianH
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Translate lidar_det3d.md into corresponding Chinese version.

Modification

Translate lidar_det3d.md into corresponding Chinese version.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@YuanxianH YuanxianH mentioned this pull request Apr 2, 2022
Closed
@ZCMax ZCMax self-requested a review April 2, 2022 15:39
@YuanxianH
Copy link
Contributor Author

Thanks for the feedback. I pushed a fix. Should I resolve the conversation? （I'm new to the PR process. o((⊙﹏⊙))o.）

@ZCMax
Copy link
Collaborator

ZCMax commented Apr 6, 2022

Thanks for the feedback. I pushed a fix. Should I resolve the conversation? （I'm new to the PR process. o((⊙﹏⊙))o.）

yes, you need to resolve the conversation if you fix it, or if you have some ideas to discuss, you can leave comments in the conversation

@YuanxianH
Copy link
Contributor Author

Thanks for the feedback. I pushed a fix. Should I resolve the conversation? （I'm new to the PR process. o((⊙﹏⊙))o.）

yes, you need to resolve the conversation if you fix it, or if you have some ideas to discuss, you can leave comments in the conversation

Thank you for your patient reply. I fixed it in the new commit.

Tai-Wang
Tai-Wang reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready, just need to fix minor comments

docs/zh_cn/supported_tasks/lidar_det3d.md Outdated Show resolved Hide resolved
docs/zh_cn/supported_tasks/lidar_det3d.md Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne changed the base branch from master to dev April 13, 2022 09:04
@ZwwWayne ZwwWayne merged commit c9e60d5 into open-mmlab:dev Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZCMax ZCMax ZCMax approved these changes

@Tai-Wang Tai-Wang Tai-Wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@YuanxianH @CLAassistant @ZCMax @Tai-Wang @ZwwWayne @VVsssssk @Subjectivist @xieenze